molive/tape-drive
4
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

wip

Browse Source
This commit is contained in:
Molive
2025-05-28 21:12:45 +01:00
parent a97f96b8d2
commit fc71f54f37
6 changed files with 907 additions and 560 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Cargo.lock
Generated
+645 -382
View File
File diff suppressed because it is too large Load Diff
Cargo.toml
+8 -8
View File
@@ -6,10 +6,10 @@ edition = "2021"
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
[dependencies] [dependencies]
vulkano = "0.34" vulkano = "0.35.1"
vulkano-shaders = { version = "0.34", features = ["shaderc-debug"] } vulkano-shaders = { version = "0.35.0", features = ["shaderc-debug"] }
winit = "0.30" winit = "0.30"
vulkano-util = "0.34" vulkano-util = "0.35.0"
obj = "0.10" obj = "0.10"
bytemuck = { version = "1.13", features = [ bytemuck = { version = "1.13", features = [
@@ -18,11 +18,11 @@ bytemuck = { version = "1.13", features = [
"min_const_generics", "min_const_generics",
] } ] }
glam = "0.29" glam = "0.30.3"
egui = "0.30" egui = "0.31.1"
egui_winit_vulkano = "0.27" egui_winit_vulkano = "0.28.0"
egui_plot = "0.30" egui_plot = "0.32.1"
serde = { version = "1", features = ["derive"] } serde = { version = "1", features = ["derive"] }
serde_json = "1" serde_json = "1"
@@ -31,7 +31,7 @@ utf-8 = "0.7"
rayon = "1.7" rayon = "1.7"
rand = "0.8" rand = "0.9.1"
foldhash = "*" foldhash = "*"
log = "0.4" log = "0.4"
src/gui.rs
+1 -1
View File
@@ -194,7 +194,7 @@ pub(crate) fn gui_up(gui: &mut Gui, state: &mut GState) {
.map(|(x, y)| [x as f64, *y]) .map(|(x, y)| [x as f64, *y])
.collect::<Vec<_>>() .collect::<Vec<_>>()
.into(); .into();
let line = Line::new(fps); let line = Line::new("fps", fps);
ui.heading("FPS"); ui.heading("FPS");
Plot::new("fps") Plot::new("fps")
.view_aspect(2.0) .view_aspect(2.0)
src/instructionset.md
+5 -5
View File
@@ -1,9 +1,9 @@
# Interpreter redesign # Interpreter redesign
Ground up redesign of the interpreter Ground up redesign of the interpreter
Maximum mesh shaders at once is 32*32*2, or 2048. For 65,536 vgprs, each mesh shader can only use 32. Maximum mesh shaders per SM is 128. For 65,536 vgprs, each mesh shader can use 512.
Instead of a stack, use SSA and then limited registers . This is a bit more compile friendly. Instead of a stack, use SSA and then limited registers. This is a bit more compile friendly.
There are 16 available registers. Register 0 is always 0, and register 15 is the next item in the const tape. There are 16 available registers. Register 0 is always 0, and register 15 is the next item in the const tape.
This leaves 14 usable 32 bit float registers. This leaves 14 usable 32 bit float registers.
@@ -21,9 +21,9 @@ array of 8 floats, and at the end they are evaluated once.
Steps: Steps:
1. 8x8x1 task shaders per mesh (64) 1. 8x8x1 task shaders per mesh (64)
2. each task shader works out 2x2x8 blocks (32) where 8 is depth 2. each task shader works out 4x4x2 blocks (32) where 2 is depth
3. each task shader spawns 4x4x2 (8x8x1?) mesh shaders per block. 3. each task shader spawns 2x2x32 (128) mesh shaders per block.
4. each mesh shader outputs 4 verts and 2 triangles, for a total 128/64 per workgroup. 4. each subgroup outputs 4 verts and 2 triangles, for a total 16/8 per workgroup.
For a mesh that takes up 1024x1024 pixel on screen, each quad takes up 16x16 pixels. For a mesh that takes up 1024x1024 pixel on screen, each quad takes up 16x16 pixels.
src/main.rs
+50 -20
View File
@@ -23,6 +23,7 @@ use foldhash::{HashMap, HashMapExt, HashSet};
use glam::{self, EulerRot, Mat3, Mat4, Vec3, vec3}; use glam::{self, EulerRot, Mat3, Mat4, Vec3, vec3};
use log::{error, info, trace}; use log::{error, info, trace};
use rayon::prelude::*; use rayon::prelude::*;
use rspirv::binary::Disassemble;
use simplelog::{CombinedLogger, Config, TermLogger, WriteLogger}; use simplelog::{CombinedLogger, Config, TermLogger, WriteLogger};
use ssa::{SSAInput, SSAOpcode, SSAOpcodeSized, SSATape}; use ssa::{SSAInput, SSAOpcode, SSAOpcodeSized, SSATape};
use vulkano::{ use vulkano::{
@@ -206,7 +207,9 @@ impl App {
let library = VulkanLibrary::new().expect("Vulkan is not installed???"); let library = VulkanLibrary::new().expect("Vulkan is not installed???");
let required_extensions = Surface::required_extensions(event_loop).unwrap(); let required_extensions = Surface::required_extensions(event_loop).unwrap();
let instance = Instance::new(library, InstanceCreateInfo { let instance = Instance::new(
library,
InstanceCreateInfo {
enabled_extensions: InstanceExtensions { enabled_extensions: InstanceExtensions {
ext_surface_maintenance1: true, ext_surface_maintenance1: true,
..required_extensions ..required_extensions
@@ -216,7 +219,8 @@ impl App {
application_name: Some(env!("CARGO_PKG_NAME").to_owned()), application_name: Some(env!("CARGO_PKG_NAME").to_owned()),
application_version: app_version(), application_version: app_version(),
..Default::default() ..Default::default()
}) },
)
.unwrap(); .unwrap();
let mut device_extensions = DeviceExtensions { let mut device_extensions = DeviceExtensions {
@@ -290,7 +294,9 @@ impl App {
device_extensions.khr_dynamic_rendering = true; device_extensions.khr_dynamic_rendering = true;
} }
let (device, mut queues) = Device::new(physical_device, DeviceCreateInfo { let (device, mut queues) = Device::new(
physical_device,
DeviceCreateInfo {
enabled_extensions: device_extensions, enabled_extensions: device_extensions,
queue_create_infos: vec![ queue_create_infos: vec![
QueueCreateInfo { QueueCreateInfo {
@@ -318,7 +324,8 @@ impl App {
..DeviceFeatures::empty() ..DeviceFeatures::empty()
}, },
..Default::default() ..Default::default()
}) },
)
.expect("Unable to initialize device"); .expect("Unable to initialize device");
let graphics_queue = queues.next().expect("Unable to retrieve queues"); let graphics_queue = queues.next().expect("Unable to retrieve queues");
@@ -334,13 +341,15 @@ impl App {
Default::default(), Default::default(),
)); ));
let uniform_buffer_allocator = let uniform_buffer_allocator = SubbufferAllocator::new(
SubbufferAllocator::new(memory_allocator.clone(), SubbufferAllocatorCreateInfo { memory_allocator.clone(),
SubbufferAllocatorCreateInfo {
buffer_usage: BufferUsage::UNIFORM_BUFFER | BufferUsage::STORAGE_BUFFER, buffer_usage: BufferUsage::UNIFORM_BUFFER | BufferUsage::STORAGE_BUFFER,
memory_type_filter: MemoryTypeFilter::PREFER_DEVICE memory_type_filter: MemoryTypeFilter::PREFER_DEVICE
| MemoryTypeFilter::HOST_SEQUENTIAL_WRITE, | MemoryTypeFilter::HOST_SEQUENTIAL_WRITE,
..Default::default() ..Default::default()
}); },
);
let pipeline_cache = get_pipeline_cache(device.clone()); let pipeline_cache = get_pipeline_cache(device.clone());
@@ -546,10 +555,13 @@ impl ApplicationHandler for App {
let surface_capabilities = self let surface_capabilities = self
.device .device
.physical_device() .physical_device()
.surface_capabilities(&surface, SurfaceInfo { .surface_capabilities(
&surface,
SurfaceInfo {
present_mode: Some(present_mode), present_mode: Some(present_mode),
..Default::default() ..Default::default()
}) },
)
.unwrap(); .unwrap();
let (image_format, _) = self let (image_format, _) = self
@@ -558,7 +570,10 @@ impl ApplicationHandler for App {
.surface_formats(&surface, Default::default()) .surface_formats(&surface, Default::default())
.unwrap()[0]; .unwrap()[0];
Swapchain::new(self.device.clone(), surface.clone(), SwapchainCreateInfo { Swapchain::new(
self.device.clone(),
surface.clone(),
SwapchainCreateInfo {
min_image_count: 3 min_image_count: 3
.max(surface_capabilities.min_image_count) .max(surface_capabilities.min_image_count)
.min(surface_capabilities.max_image_count.unwrap_or(u32::MAX)), .min(surface_capabilities.max_image_count.unwrap_or(u32::MAX)),
@@ -577,7 +592,8 @@ impl ApplicationHandler for App {
present_mode, present_mode,
..Default::default() ..Default::default()
}) },
)
.unwrap() .unwrap()
}; };
@@ -1304,10 +1320,13 @@ impl App {
} }
builder builder
.next_subpass(Default::default(), SubpassBeginInfo { .next_subpass(
Default::default(),
SubpassBeginInfo {
contents: SubpassContents::SecondaryCommandBuffers, contents: SubpassContents::SecondaryCommandBuffers,
..Default::default() ..Default::default()
}) },
)
.unwrap() .unwrap()
.execute_commands(guicb) .execute_commands(guicb)
.unwrap() .unwrap()
@@ -1400,7 +1419,9 @@ fn framebuffer_generation(
.map(|image| { .map(|image| {
let view = ImageView::new_default(image.clone()).unwrap(); let view = ImageView::new_default(image.clone()).unwrap();
Framebuffer::new(render_pass.clone(), FramebufferCreateInfo { Framebuffer::new(
render_pass.clone(),
FramebufferCreateInfo {
attachments: if MSAA_ENABLE { attachments: if MSAA_ENABLE {
vec![ vec![
intermediary.as_ref().unwrap().clone(), intermediary.as_ref().unwrap().clone(),
@@ -1411,7 +1432,8 @@ fn framebuffer_generation(
vec![view, depth_buffer.clone()] vec![view, depth_buffer.clone()]
}, },
..Default::default() ..Default::default()
}) },
)
.unwrap() .unwrap()
}) })
.collect::<Vec<_>>(); .collect::<Vec<_>>();
@@ -1733,6 +1755,7 @@ fn object_size_dependent_setup(
for csg in state { for csg in state {
let tape = csg.parts.compile_to_gpu(); let tape = csg.parts.compile_to_gpu();
let tape2 = csg.parts.compile_to_spirv();
let mut description = implicit_fs::Description::default(); let mut description = implicit_fs::Description::default();
@@ -1820,11 +1843,15 @@ fn object_size_dependent_setup(
) )
.unwrap(); .unwrap();
let staging = SubbufferAllocator::new(allocator.clone(), SubbufferAllocatorCreateInfo { let staging = SubbufferAllocator::new(
allocator.clone(),
SubbufferAllocatorCreateInfo {
buffer_usage: BufferUsage::TRANSFER_SRC, buffer_usage: BufferUsage::TRANSFER_SRC,
memory_type_filter: MemoryTypeFilter::PREFER_HOST | MemoryTypeFilter::HOST_SEQUENTIAL_WRITE, memory_type_filter: MemoryTypeFilter::PREFER_HOST
| MemoryTypeFilter::HOST_SEQUENTIAL_WRITE,
..Default::default() ..Default::default()
}); },
);
let csg_scene = gpu_buffer( let csg_scene = gpu_buffer(
&[&scene], &[&scene],
@@ -1884,10 +1911,13 @@ fn get_pipeline_cache(device: Arc<Device>) -> Arc<PipelineCache> {
}; };
unsafe { unsafe {
PipelineCache::new(device, PipelineCacheCreateInfo { PipelineCache::new(
device,
PipelineCacheCreateInfo {
initial_data, initial_data,
..Default::default() ..Default::default()
}) },
)
} }
.unwrap() .unwrap()
} }
src/ssa.rs
+135 -81
View File
@@ -484,6 +484,8 @@ impl SSATape {
.unwrap(); .unwrap();
let pos = b.function_parameter(vec3).unwrap(); let pos = b.function_parameter(vec3).unwrap();
b.begin_block(None).unwrap();
let mut mapping = HashMap::<u32, u32>::new(); let mut mapping = HashMap::<u32, u32>::new();
for (line, instruction) in self.tape.iter().enumerate() { for (line, instruction) in self.tape.iter().enumerate() {
@@ -667,10 +669,13 @@ impl SSATape {
&mut mapping, &mut mapping,
instruction, instruction,
|b, val_a, val_b| { |b, val_a, val_b| {
b.ext_inst(float, None, glsl, spirv::GLOp::Atan2 as u32, [ b.ext_inst(
IdRef(val_a), float,
IdRef(val_b), None,
]) glsl,
spirv::GLOp::Atan2 as u32,
[IdRef(val_a), IdRef(val_b)],
)
.unwrap() .unwrap()
}, },
); );
@@ -682,10 +687,13 @@ impl SSATape {
&mut mapping, &mut mapping,
instruction, instruction,
|b, val_a, val_b| { |b, val_a, val_b| {
b.ext_inst(float, None, glsl, spirv::GLOp::FMin as u32, [ b.ext_inst(
IdRef(val_a), float,
IdRef(val_b), None,
]) glsl,
spirv::GLOp::FMin as u32,
[IdRef(val_a), IdRef(val_b)],
)
.unwrap() .unwrap()
}, },
); );
@@ -698,10 +706,13 @@ impl SSATape {
&mut mapping, &mut mapping,
instruction, instruction,
|b, val_a, val_b| { |b, val_a, val_b| {
b.ext_inst(float, None, glsl, spirv::GLOp::FMax as u32, [ b.ext_inst(
IdRef(val_a), float,
IdRef(val_b), None,
]) glsl,
spirv::GLOp::FMax as u32,
[IdRef(val_a), IdRef(val_b)],
)
.unwrap() .unwrap()
}, },
); );
@@ -717,10 +728,13 @@ impl SSATape {
let val_a = b.composite_construct(vec3, None, [a_x, a_y, a_z]).unwrap(); let val_a = b.composite_construct(vec3, None, [a_x, a_y, a_z]).unwrap();
let val_b = b.composite_construct(vec3, None, [b_x, b_y, b_z]).unwrap(); let val_b = b.composite_construct(vec3, None, [b_x, b_y, b_z]).unwrap();
let cross = b let cross = b
.ext_inst(vec3, None, glsl, spirv::GLOp::Cross as u32, [ .ext_inst(
IdRef(val_a), vec3,
IdRef(val_b), None,
]) glsl,
spirv::GLOp::Cross as u32,
[IdRef(val_a), IdRef(val_b)],
)
.unwrap(); .unwrap();
mapping.insert( mapping.insert(
instruction.outputs[0], instruction.outputs[0],
@@ -761,9 +775,13 @@ impl SSATape {
let vector = [void, vec1, vec2, vec3, vec4][instruction.opcode.size as usize]; let vector = [void, vec1, vec2, vec3, vec4][instruction.opcode.size as usize];
let val_a = b.composite_construct(vector, None, val_a).unwrap(); let val_a = b.composite_construct(vector, None, val_a).unwrap();
let length = b let length = b
.ext_inst(float, None, glsl, spirv::GLOp::Length as u32, [IdRef( .ext_inst(
val_a, float,
)]) None,
glsl,
spirv::GLOp::Length as u32,
[IdRef(val_a)],
)
.unwrap(); .unwrap();
mapping.insert(instruction.outputs[0], length); mapping.insert(instruction.outputs[0], length);
}, },
@@ -782,10 +800,13 @@ impl SSATape {
let val_a = b.composite_construct(vector, None, val_a).unwrap(); let val_a = b.composite_construct(vector, None, val_a).unwrap();
let val_b = b.composite_construct(vector, None, val_b).unwrap(); let val_b = b.composite_construct(vector, None, val_b).unwrap();
let distance = b let distance = b
.ext_inst(float, None, glsl, spirv::GLOp::Distance as u32, [ .ext_inst(
IdRef(val_a), float,
IdRef(val_b), None,
]) glsl,
spirv::GLOp::Distance as u32,
[IdRef(val_a), IdRef(val_b)],
)
.unwrap(); .unwrap();
mapping.insert(instruction.outputs[0], distance); mapping.insert(instruction.outputs[0], distance);
}, },
@@ -804,10 +825,13 @@ impl SSATape {
let val_a = b.composite_construct(vector, None, val_a).unwrap(); let val_a = b.composite_construct(vector, None, val_a).unwrap();
let val_b = b.composite_construct(vector, None, val_b).unwrap(); let val_b = b.composite_construct(vector, None, val_b).unwrap();
let normal = b let normal = b
.ext_inst(vector, None, glsl, spirv::GLOp::Normalize as u32, [ .ext_inst(
IdRef(val_a), vector,
IdRef(val_b), None,
]) glsl,
spirv::GLOp::Normalize as u32,
[IdRef(val_a), IdRef(val_b)],
)
.unwrap(); .unwrap();
for i in 0..instruction.opcode.size as usize { for i in 0..instruction.opcode.size as usize {
mapping.insert( mapping.insert(
@@ -933,21 +957,25 @@ impl SSATape {
let div_k = b.f_div(float, None, mul_half, k).unwrap(); let div_k = b.f_div(float, None, mul_half, k).unwrap();
let add_half = b.f_add(float, None, div_k, half_const).unwrap(); let add_half = b.f_add(float, None, div_k, half_const).unwrap();
let h = b let h = b
.ext_inst(float, None, glsl, spirv::GLOp::FClamp as u32, [ .ext_inst(
IdRef(add_half), float,
IdRef(zero_const), None,
IdRef(one_const), glsl,
]) spirv::GLOp::FClamp as u32,
[IdRef(add_half), IdRef(zero_const), IdRef(one_const)],
)
.unwrap(); .unwrap();
let negh = b.f_sub(float, None, one_const, h).unwrap(); let negh = b.f_sub(float, None, one_const, h).unwrap();
let h_negh = b.f_mul(float, None, h, negh).unwrap(); let h_negh = b.f_mul(float, None, h, negh).unwrap();
let kh_negh = b.f_mul(float, None, k, h_negh).unwrap(); let kh_negh = b.f_mul(float, None, k, h_negh).unwrap();
let mix = b let mix = b
.ext_inst(float, None, glsl, spirv::GLOp::FMix as u32, [ .ext_inst(
IdRef(d2), float,
IdRef(d1), None,
IdRef(h), glsl,
]) spirv::GLOp::FMix as u32,
[IdRef(d2), IdRef(d1), IdRef(h)],
)
.unwrap(); .unwrap();
b.f_sub(float, None, mix, kh_negh).unwrap() b.f_sub(float, None, mix, kh_negh).unwrap()
}); });
@@ -962,22 +990,26 @@ impl SSATape {
let div_k = b.f_div(float, None, mul_half, k).unwrap(); let div_k = b.f_div(float, None, mul_half, k).unwrap();
let add_half = b.f_sub(float, None, half_const, div_k).unwrap(); let add_half = b.f_sub(float, None, half_const, div_k).unwrap();
let h = b let h = b
.ext_inst(float, None, glsl, spirv::GLOp::FClamp as u32, [ .ext_inst(
IdRef(add_half), float,
IdRef(zero_const), None,
IdRef(one_const), glsl,
]) spirv::GLOp::FClamp as u32,
[IdRef(add_half), IdRef(zero_const), IdRef(one_const)],
)
.unwrap(); .unwrap();
let negh = b.f_sub(float, None, one_const, h).unwrap(); let negh = b.f_sub(float, None, one_const, h).unwrap();
let h_negh = b.f_mul(float, None, h, negh).unwrap(); let h_negh = b.f_mul(float, None, h, negh).unwrap();
let kh_negh = b.f_mul(float, None, k, h_negh).unwrap(); let kh_negh = b.f_mul(float, None, k, h_negh).unwrap();
let negate = b.f_negate(float, None, d1).unwrap(); let negate = b.f_negate(float, None, d1).unwrap();
let mix = b let mix = b
.ext_inst(float, None, glsl, spirv::GLOp::FMix as u32, [ .ext_inst(
IdRef(d2), float,
IdRef(negate), None,
IdRef(h), glsl,
]) spirv::GLOp::FMix as u32,
[IdRef(d2), IdRef(negate), IdRef(h)],
)
.unwrap(); .unwrap();
b.f_add(float, None, mix, kh_negh).unwrap() b.f_add(float, None, mix, kh_negh).unwrap()
}); });
@@ -991,11 +1023,13 @@ impl SSATape {
&mut mapping, &mut mapping,
instruction, instruction,
|b, val_a, val_b, val_c| { |b, val_a, val_b, val_c| {
b.ext_inst(float, None, glsl, spirv::GLOp::FClamp as u32, [ b.ext_inst(
IdRef(val_a), float,
IdRef(val_b), None,
IdRef(val_c), glsl,
]) spirv::GLOp::FClamp as u32,
[IdRef(val_a), IdRef(val_b), IdRef(val_c)],
)
.unwrap() .unwrap()
}, },
); );
@@ -1007,11 +1041,13 @@ impl SSATape {
&mut mapping, &mut mapping,
instruction, instruction,
|b, val_a, val_b, val_c| { |b, val_a, val_b, val_c| {
b.ext_inst(float, None, glsl, spirv::GLOp::FMix as u32, [ b.ext_inst(
IdRef(val_a), float,
IdRef(val_b), None,
IdRef(val_c), glsl,
]) spirv::GLOp::FMix as u32,
[IdRef(val_a), IdRef(val_b), IdRef(val_c)],
)
.unwrap() .unwrap()
}, },
); );
@@ -1023,11 +1059,13 @@ impl SSATape {
&mut mapping, &mut mapping,
instruction, instruction,
|b, val_a, val_b, val_c| { |b, val_a, val_b, val_c| {
b.ext_inst(float, None, glsl, spirv::GLOp::Fma as u32, [ b.ext_inst(
IdRef(val_a), float,
IdRef(val_b), None,
IdRef(val_c), glsl,
]) spirv::GLOp::Fma as u32,
[IdRef(val_a), IdRef(val_b), IdRef(val_c)],
)
.unwrap() .unwrap()
}, },
); );
@@ -1078,38 +1116,54 @@ impl SSATape {
.composite_construct(vec3, None, [zero, zero, zero]) .composite_construct(vec3, None, [zero, zero, zero])
.unwrap(); .unwrap();
let q_limit = b let q_limit = b
.ext_inst(vec3, None, glsl, spirv::GLOp::FMax as u32, [ .ext_inst(
IdRef(q), vec3,
IdRef(zero_vec3), None,
]) glsl,
spirv::GLOp::FMax as u32,
[IdRef(q), IdRef(zero_vec3)],
)
.unwrap(); .unwrap();
let length = b let length = b
.ext_inst(float, None, glsl, spirv::GLOp::Length as u32, [IdRef( .ext_inst(
q_limit, float,
)]) None,
glsl,
spirv::GLOp::Length as u32,
[IdRef(q_limit)],
)
.unwrap(); .unwrap();
let q_x = b.composite_extract(float, None, q, [0]).unwrap(); let q_x = b.composite_extract(float, None, q, [0]).unwrap();
let q_y = b.composite_extract(float, None, q, [1]).unwrap(); let q_y = b.composite_extract(float, None, q, [1]).unwrap();
let q_z = b.composite_extract(float, None, q, [2]).unwrap(); let q_z = b.composite_extract(float, None, q, [2]).unwrap();
let max1 = b let max1 = b
.ext_inst(float, None, glsl, spirv::GLOp::FMax as u32, [ .ext_inst(
IdRef(q_x), float,
IdRef(q_y), None,
]) glsl,
spirv::GLOp::FMax as u32,
[IdRef(q_x), IdRef(q_y)],
)
.unwrap(); .unwrap();
let max2 = b let max2 = b
.ext_inst(float, None, glsl, spirv::GLOp::FMax as u32, [ .ext_inst(
IdRef(max1), float,
IdRef(q_z), None,
]) glsl,
spirv::GLOp::FMax as u32,
[IdRef(max1), IdRef(q_z)],
)
.unwrap(); .unwrap();
let min = b let min = b
.ext_inst(float, None, glsl, spirv::GLOp::FMax as u32, [ .ext_inst(
IdRef(max2), float,
IdRef(zero), None,
]) glsl,
spirv::GLOp::FMax as u32,
[IdRef(max2), IdRef(zero)],
)
.unwrap(); .unwrap();
mapping.insert( mapping.insert(